Standardize Arduino form factor #9593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FF1705_L151CC does not have the following pins D4, D5, D6, D7, D8, D9, A2, A3, A4, A5 so remove the ARDUINO form factor from it.
Remove the ARDUINO form factor from the RBLAB_BLENANO2 since it does not have D11, D12, D14, D15 defined and does not physically have the arduino form factor.
Remove ARDUINO from supported form factors on devices which have the physical form factor of the arduino nano.
Set A0 to NC so it is defined on the KW41Z platform.
Define the unconnected Arduino pins to NC so they are all defined.
Merged
|
@c1728p9, thank you for your changes. |
jeromecoutant
approved these changes
Feb 4, 2019
0xc0170
approved these changes
Feb 4, 2019
|
Ci started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
ARDUINOfromsupported_form_factorson devices which physically do not have the Arduinoform factor. Also ensure that all Arduino pins are defined for targets with the Arduino form factor, even if they are set to NC.This PR is a subset of the pinmap work in #9449.
Pull request type
Reviewers